Updated navbar to use latest design.#617
Conversation
9f60f83 to
4d7d4a9
Compare
|
Instead of adding the Alternatively, we could mount a pre-processing middleware that strips the if (process.env.BASE_HREF && process.env.BASE_HREF != '/') {
const baseHref = process.env.BASE_HREF.replace(/\/+$/, '')
app.use((req, res, next) => {
if (req.url == '/' || req.url == baseHref) {
res.redirect(302, baseHref+'/')
} else if (req.url.startsWith(baseHref+'/')) {
req.url = req.url.slice(baseHref.length)
next()
} else {
res.sendStatus(404)
}
})
}Personally I've just been making sure to run the dev-server with |
|
Mounted router onto base path and removed prefix from individual routes |
|
lgtm |
|
Otherwise, it's good - good work |
|
|
Updated PR to add proper stylings for light theme and raised the target width for nav link line wraps. I also fixed the issue of the mobile menu not closing on certain screen sizes since it only required a small change. EDIT: Also addressed @sprihozhiy brought up regarding the page refresh when the network selector was touched on mobile |
The solution for the pointer icon above. I understand that this is a redesign overall, but we can fix the bugs related to this part.
Ok
Ok
It’s up to you, but this seems a bit odd. Maybe it’s just me.
It looks better; you could also add a gap to avoid that
Looks good, thanks
It's working now; I don't know if you changed anything |
There was a problem hiding this comment.
It’s visually apparent in the UI that the two icons (Liquid and Bitcoin) are slightly different sizes. This is especially noticeable when you zoom in on them. It’s not a major issue, but it’s better to upload the icons at the exact size, without any padding.
In general, keeping PRs focused on their main purpose helps make them easier to review and avoids mixing in unrelated changes. Even small changes can be easy to overlook if they’re assumed to be directly tied to the main goal of the PR, which can introduce risk. I’ll go ahead and add the cursor to the hover icon here since it’s small and closely related.
The nav bar items are currently spaced using flexbox’s space-between, which works well for larger screens. I’ll incorporate your suggestion for smaller screen sizes where it can help improve the layout. |
|
Pushed updated commit with cropped svg icons, stylings on the search input's clear icon, and an un-commented |












To run locally, npm install and use the following snippets:
Mainnet
Current design:

New design:

Testnet
Current design:

New design:
